Introduce basic glob support to option handling #2365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devoncarew
approved these changes
Sep 29, 2020
lib/src/dartdoc_options.dart
Outdated
| @@ -433,6 +433,17 @@ class _YamlFileData { | |||
| _YamlFileData(this.data, this.canonicalDirectoryPath); | |||
| } | |||
|
|
|||
| /// An enum to specify the multiple different kinds of data an option might | |||
| /// represent. | |||
| enum OptionDataIs { | |||
There was a problem hiding this comment.
I think I'll go with OptionKind, the only other uses we have of kind are pretty far away from here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is now possible to create options that understand globs, or port existing options that currently understand only files to understand globs as well.
This PR doesn't actually do matching on globs anywhere (that will be the option user's responsibility), but will properly handle context, config file parsing, and argument/file conflicts to compute a glob that will be matchable.
This is technically a breaking change on the
DartdocOptionclass constructor, however you can change code with a very simple text substitution to get identical behavior so I think it is acceptable given the limited number of potential extenders.